Re: [PATCH v1] MAINTAINERS: Sort entries in database for VSPRINTF

From: Petr Mladek
Date: Tue Feb 11 2020 - 06:45:12 EST


On Mon 2020-02-10 16:51:29, Andy Shevchenko wrote:
> On Mon, Feb 10, 2020 at 03:21:55PM +0100, Petr Mladek wrote:
> > Hi Andy,
> >
> > On Tue 2020-01-28 16:34:25, Andy Shevchenko wrote:
> > > Run parse-maintainers.pl and choose VSPRINTF record. Fix it accordingly.
> >
> > Also the order does not look defined in the file. When I run
> > parse-maintainers.pl on the entire MAINTAINERS file:
>
> See [2] for the details.
>
> > MAINTAINERS | 5584 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------------------------------------------------------
> > 1 file changed, 2787 insertions(+), 2797 deletions(-)
> >
> > The file has 18545 lines. It means that huge amount of entries
> > do not follow the order.
>
> Yes, but it's getting better.
>
> [1]: 7683e9e52925 ("Properly alphabetize MAINTAINERS file")
> [2]: https://lore.kernel.org/lkml/CA+55aFy3naVgbRubhjfq7k4CcSiFOEdQNkNwHTLDLmepECu9yA@xxxxxxxxxxxxxx/

Ok, the message [2] is Linus' reaction on a similar patch.
He complained that

(a) the ordering wasn't complete
(b) this wasn't scripted.

In fact, parse-maintainers.pl was created to automatize such clean ups
and allow to fix all entries at once.

Fixing only VSPRITF record is a tiny-piece-by-piece approach.
It is an approach that will create a lot of work for many people.

If you want to do a clean up then please ask Linus to do it by the
script.

Also please add a check into checkpatch.pl to reduce regressions.

Best Regards,
Petr