Re: [PATCH -next] dmaengine: idxd: remove set but not used variable 'group'

[Dave Jiang]

On 2/11/20 6:53 AM, YueHaibing wrote:
> drivers/dma/idxd/sysfs.c: In function engine_group_id_store:
> drivers/dma/idxd/sysfs.c:419:29: warning: variable group set but not used [-Wunused-but-set-variable]
>
> It is not used, so remove it.
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>

Acked-by: Dave Jiang <dave.jiang@xxxxxxxxx>

> ---
>   drivers/dma/idxd/sysfs.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/dma/idxd/sysfs.c b/drivers/dma/idxd/sysfs.c
> index 6d907fe..e4f35bd 100644
> --- a/drivers/dma/idxd/sysfs.c
> +++ b/drivers/dma/idxd/sysfs.c
> @@ -416,7 +416,7 @@ static ssize_t engine_group_id_store(struct device *dev,
>   	struct idxd_device *idxd = engine->idxd;
>   	long id;
>   	int rc;
> -	struct idxd_group *prevg, *group;
> +	struct idxd_group *prevg;
>   
>   	rc = kstrtol(buf, 10, &id);
>   	if (rc < 0)
> @@ -436,7 +436,6 @@ static ssize_t engine_group_id_store(struct device *dev,
>   		return count;
>   	}
>   
> -	group = &idxd->groups[id];
>   	prevg = engine->group;
>   
>   	if (prevg)