Re: [PATCH v2 10/25] fs: Introduce i_blocks_per_page

From: Christoph Hellwig
Date: Wed Feb 12 2020 - 02:44:55 EST


Looks good modulo some nitpicks below:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

> + * Context: Any context.

Does this add any value for a trivial helper like this?

> + * Return: The number of filesystem blocks covered by this page.
> + */
> +static inline
> +unsigned int i_blocks_per_page(struct inode *inode, struct page *page)

static inline unisnged int
i_blocks_per_page(struct inode *inode, struct page *page)