Re: [PATCH] ARM: dts: imx6dl-colibri-eval-v3: fix sram compatible properties

[Oleksandr Suvorov]

On Wed, Feb 12, 2020 at 12:46 PM Johan Hovold <johan@xxxxxxxxxx> wrote:
>
> The sram-node compatible properties have mistakingly combined the
> model-specific string with the generic "mtd-ram" string.
>
> Note that neither "cy7c1019dv33-10zsxi, mtd-ram" or
> "cy7c1019dv33-10zsxi" are used by any in-kernel driver and they are
> not present in any binding.
>
> The physmap driver will however bind to platform devices that specify
> "mtd-ram".
>
> Fixes: fc48e76489fd ("ARM: dts: imx6: Add support for Toradex Colibri iMX6 module")
> Cc: Sanchayan Maity <maitysanchayan@xxxxxxxxx>
> Cc: Marcel Ziswiler <marcel.ziswiler@xxxxxxxxxxx>
> Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
> Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>

Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov@xxxxxxxxxxx>

> ---
>  arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts b/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts
> index cd075621de52..84fcc203a2e4 100644
> --- a/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts
> +++ b/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts
> @@ -275,7 +275,7 @@ &weim {
>
>         /* SRAM on Colibri nEXT_CS0 */
>         sram@0,0 {
> -               compatible = "cypress,cy7c1019dv33-10zsxi, mtd-ram";
> +               compatible = "cypress,cy7c1019dv33-10zsxi", "mtd-ram";
>                 reg = <0 0 0x00010000>;
>                 #address-cells = <1>;
>                 #size-cells = <1>;
> @@ -286,7 +286,7 @@ sram@0,0 {
>
>         /* SRAM on Colibri nEXT_CS1 */
>         sram@1,0 {
> -               compatible = "cypress,cy7c1019dv33-10zsxi, mtd-ram";
> +               compatible = "cypress,cy7c1019dv33-10zsxi", "mtd-ram";
>                 reg = <1 0 0x00010000>;
>                 #address-cells = <1>;
>                 #size-cells = <1>;
> --
> 2.24.1
>


--
Best regards

Oleksandr Suvorov
cryosay@xxxxxxxxx