Re: [PATCH 06/10] microblaze: Add sync to tlb operations

[Michal Simek]

On 12. 02. 20 14:00, Arnd Bergmann wrote:
> On Wed, Feb 12, 2020 at 9:58 AM Michal Simek <michal.simek@xxxxxxxxxx> wrote:
>> diff --git a/arch/microblaze/kernel/misc.S b/arch/microblaze/kernel/misc.S
>> index 6759af688451..1228a09d8109 100644
>> --- a/arch/microblaze/kernel/misc.S
>> +++ b/arch/microblaze/kernel/misc.S
>> @@ -39,7 +39,7 @@ _tlbia_1:
>>         rsubi   r11, r12, MICROBLAZE_TLB_SIZE - 1
>>         bneid   r11, _tlbia_1 /* loop for all entries */
>>         addik   r12, r12, 1
>> -       /* sync */
>> +       mbar    1 /* sync */
>>         rtsd    r15, 8
>>         nop
>>         .size  _tlbia, . - _tlbia
> 
> Is there any effect on non-SMP systems?

not - it is just nop.

M