Re: [PATCH] HID: logitech-dj: add debug msg when exporting a HID++ report descriptors

From: Jiri Kosina
Date: Wed Feb 12 2020 - 08:45:13 EST


On Mon, 13 Jan 2020, Filipe LaÃns wrote:

> When exporting all other types of report descriptors we print a debug
> message. Not doing so for HID++ descriptors makes unaware users think
> that no HID++ descriptor was exported.
>
> Signed-off-by: Filipe LaÃns <lains@xxxxxxxxxxxxx>
> ---
> drivers/hid/hid-logitech-dj.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c
> index cc7fc71d8b05..8f17a29b5a94 100644
> --- a/drivers/hid/hid-logitech-dj.c
> +++ b/drivers/hid/hid-logitech-dj.c
> @@ -1368,6 +1368,8 @@ static int logi_dj_ll_parse(struct hid_device *hid)
> }
>
> if (djdev->reports_supported & HIDPP) {
> + dbg_hid("%s: sending a HID++ descriptor, reports_supported: %llx\n",
> + __func__, djdev->reports_supported);
> rdcat(rdesc, &rsize, hidpp_descriptor,
> sizeof(hidpp_descriptor));

Applied, thanks.

--
Jiri Kosina
SUSE Labs