Re: [PATCH] watchdog: da9062: Add dependency on I2C

From: Geert Uytterhoeven
Date: Wed Feb 12 2020 - 09:13:04 EST


On Sat, Feb 8, 2020 at 2:09 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
> Since commit 057b52b4b3d58 ("watchdog: da9062: make restart handler atomic
> safe"), the driver calls i2c functions directly. It now therefore depends
> on I2C. This is a hard dependency which overrides COMPILE_TEST.
>
> Reported-by: kbuild test robot <lkp@xxxxxxxxx>
> Fixes: 057b52b4b3d58 ("watchdog: da9062: make restart handler atomic safe")
> Cc: Marco Felsch <m.felsch@xxxxxxxxxxxxxx>
> Cc: Adam Thomson <Adam.Thomson.Opensource@xxxxxxxxxxx>
> Cc: Stefan Lengfeld <contact@xxxxxxxxxxxxxxx>
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Just ran into the same issue, so
Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds