Re: [alsa-devel] [PATCH v2 5/5] soundwire: intel: free all resources on hw_free()

[Pierre-Louis Bossart]

Hi Vinod,

> > +static int intel_free_stream(struct sdw_intel *sdw,
> > +			     struct snd_pcm_substream *substream,
> > +			     struct snd_soc_dai *dai,
> > +			     int link_id)
> > +{
> > +	struct sdw_intel_link_res *res = sdw->link_res;
> > +	struct sdw_intel_stream_free_data free_data;
>
> where is this struct sdw_intel_stream_free_data defined. I dont see it
> in this patch or this series..

the definition is already upstream :-)

It was added in December with

4b206d34b92224 ('soundwire: intel: update stream callbacks for 
hwparams/free stream operations')

> > -	return ret;
> > +	ret = intel_free_stream(sdw, substream, dai, sdw->instance);
> > +	if (ret < 0) {
> > +		dev_err(dai->dev, "intel_free_stream: failed %d", ret);
> > +		return ret;
> > +	}
> > +
> > +	sdw_release_stream(dma->stream);
>
> I think, free the 'name' here would be apt

Right, this is something we discussed with Rander shortly before Chinese 
New Year and we wanted to handle this with a follow-up patch, would that 
work for you? if not I can send a v3, your choice.

Thanks
-Pierre