Re: [PATCH 14/62] x86/boot/compressed/64: Add stage1 #VC handler

[Andy Lutomirski]

> On Feb 12, 2020, at 3:38 AM, Joerg Roedel <joro@xxxxxxxxxx> wrote:
> 
> ïOn Tue, Feb 11, 2020 at 02:23:22PM -0800, Andy Lutomirski wrote:
>>> On Tue, Feb 11, 2020 at 5:53 AM Joerg Roedel <joro@xxxxxxxxxx> wrote:
>>> +void __init no_ghcb_vc_handler(struct pt_regs *regs)
>> 
>> Isn't there a second parameter: unsigned long error_code?
> 
> No, the function gets the error-code from regs->orig_ax. This particular
> function only needs to check for error_code == SVM_EXIT_CPUID, as that
> is the only one supported when there is no GHCB.
> 

Hmm. It might be nice to use the same signature for early handlers as for normal ones.

> Regards,
> 
>    Joerg