Re: Linux 5.6-rc1 kselftest build failures

[shuah]

On 2/12/20 1:14 AM, Aleksa Sarai wrote:
> On 2020-02-11, shuah <shuah@xxxxxxxxxx> wrote:
> > openat2:
> >
> > tools/testing/selftests/openat2'
> > gcc -Wall -O2 -g -fsanitize=address -fsanitize=undefined openat2_test.c
> > helpers.c  -o tools/testing/selftests/openat2/openat2_test
> > In file included from /usr/include/fcntl.h:301,
> >                   from helpers.c:9:
> > In function âopenatâ,
> >      inlined from âtouchatâ at helpers.c:49:11:
> > /usr/include/x86_64-linux-gnu/bits/fcntl2.h:126:4: error: call to
> > â__openat_missing_modeâ declared with attribute error: openat with O_CREAT
> > or O_TMPFILE in third argument needs 4 arguments
> >    126 |    __openat_missing_mode ();
> >        |    ^~~~~~~~~~~~~~~~~~~~~~~~
>
> Yeah, that's a brain-o -- it looks like you have a newer glibc than
> me which gives you a warning when you don't set the mode. The fix should
> be just the following:

Nice. Do you mind sending a proper patch, I can pull in.

thanks,
-- Shuah