Re: [GIT PULL] KVM changes for Linux 5.6-rc2

[Linus Torvalds]

On Wed, Feb 12, 2020 at 8:47 AM Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote:
>
> A mix of cleanups and bugfixes, some of them slightly more invasive than usual
> but still not worth waiting for 5.7.

What? No.

> Oliver Upton (4):
>       KVM: nVMX: Emulate MTF when performing instruction emulation

This was committed today, and it's complete and utter garbage:

   CommitDate: 7 hours ago

It doesn't even compile. Just in the patch itself - so this is not a
merge issue, I see this:

          int (*skip_emulated_instruction)(struct kvm_vcpu *vcpu);
  ..
  @@ -1599,6 +1599,40 @@ static int skip_emulated_instruction(struct
kvm_vcpu *vcpu)
  ..
  +static void vmx_skip_emulated_instruction(struct kvm_vcpu *vcpu)
  +       return skip_emulated_instruction(vcpu);
  ..
  -       .skip_emulated_instruction = skip_emulated_instruction,
  +       .skip_emulated_instruction = vmx_skip_emulated_instruction,

ie note how that vmx_skip_emulated_instruction() is a void function,
and then you have

         return skip_emulated_instruction(vcpu);

in it, and you assign that garbage to ".skip_emulated_instruction"
which is supposed to be returning 'int'.

So this clearly never even got a _whiff_ of build-testing. The thing
is completely broken.

Stop sending me garbage.

You're now on my shit-list, which means that I want to see only (a)
pure fixes and (b) well-tested such. Nothing else will be pulled.

                    Linus