Re: [PATCH 1/2] arm64: dts: mt8183: Add gce setting in display node

[Bibby Hsieh]

On Wed, 2020-02-12 at 18:48 +0800, CK Hu wrote:
> On Wed, 2020-02-12 at 17:55 +0800, Bibby Hsieh wrote:
> > In order to use GCE function, we need add some information
> > into display node (mboxes, mediatek,gce-client-reg, mediatek,gce-events).
> > 
> > Signed-off-by: Bibby Hsieh <bibby.hsieh@xxxxxxxxxxxx>
> > Signed-off-by: Yongqiang Niu <yongqiang.niu@xxxxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/mediatek/mt8183.dtsi | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > index be4428c92f35..1f0fc281bc2d 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > @@ -9,6 +9,7 @@
> >  #include <dt-bindings/interrupt-controller/arm-gic.h>
> >  #include <dt-bindings/interrupt-controller/irq.h>
> >  #include <dt-bindings/power/mt8183-power.h>
> > +#include <dt-bindings/gce/mt8183-gce.h>
> >  #include "mt8183-pinfunc.h"
> >  
> >  / {
> > @@ -664,6 +665,9 @@
> >  			reg = <0 0x14000000 0 0x1000>;
> >  			power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
> >  			#clock-cells = <1>;
> > +			mboxes = <&gce 0 CMDQ_THR_PRIO_HIGHEST 1>,
> 
> I would like to remove atomic parameter, so please follow [1] to remove
> it.
> 
> [1] https://patchwork.kernel.org/patch/10765419/

Hi, CK,

Yeah, I'm trying remove atomic feature.

Thanks

Bibby
> 
> Regards,
> CK
> 
> > +				 <&gce 1 CMDQ_THR_PRIO_HIGHEST 1>;
> > +			mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0 0x1000>;
> >  		};
> >  
> >  		ovl0: ovl@14008000 {
> > @@ -672,6 +676,7 @@
> >  			interrupts = <GIC_SPI 225 IRQ_TYPE_LEVEL_LOW>;
> >  			power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
> >  			clocks = <&mmsys CLK_MM_DISP_OVL0>;
> > +			mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0x8000 0x1000>;
> >  		};
> >  
> >  		ovl_2l0: ovl@14009000 {
> > @@ -680,6 +685,7 @@
> >  			interrupts = <GIC_SPI 226 IRQ_TYPE_LEVEL_LOW>;
> >  			power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
> >  			clocks = <&mmsys CLK_MM_DISP_OVL0_2L>;
> > +			mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0x9000 0x1000>;
> >  		};
> >  
> >  		ovl_2l1: ovl@1400a000 {
> > @@ -688,6 +694,7 @@
> >  			interrupts = <GIC_SPI 227 IRQ_TYPE_LEVEL_LOW>;
> >  			power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
> >  			clocks = <&mmsys CLK_MM_DISP_OVL1_2L>;
> > +			mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0xa000 0x1000>;
> >  		};
> >  
> >  		rdma0: rdma@1400b000 {
> > @@ -697,6 +704,7 @@
> >  			power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
> >  			clocks = <&mmsys CLK_MM_DISP_RDMA0>;
> >  			mediatek,rdma_fifo_size = <5120>;
> > +			mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0xb000 0x1000>;
> >  		};
> >  
> >  		rdma1: rdma@1400c000 {
> > @@ -706,6 +714,7 @@
> >  			power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
> >  			clocks = <&mmsys CLK_MM_DISP_RDMA1>;
> >  			mediatek,rdma_fifo_size = <2048>;
> > +			mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0xc000 0x1000>;
> >  		};
> >  
> >  		color0: color@1400e000 {
> > @@ -715,6 +724,7 @@
> >  			interrupts = <GIC_SPI 231 IRQ_TYPE_LEVEL_LOW>;
> >  			power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
> >  			clocks = <&mmsys CLK_MM_DISP_COLOR0>;
> > +			mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0xe000 0x1000>;
> >  		};
> >  
> >  		ccorr0: ccorr@1400f000 {
> > @@ -723,6 +733,7 @@
> >  			interrupts = <GIC_SPI 232 IRQ_TYPE_LEVEL_LOW>;
> >  			power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
> >  			clocks = <&mmsys CLK_MM_DISP_CCORR0>;
> > +			mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0xf000 0x1000>;
> >  		};
> >  
> >  		aal0: aal@14010000 {
> > @@ -732,6 +743,7 @@
> >  			interrupts = <GIC_SPI 233 IRQ_TYPE_LEVEL_LOW>;
> >  			power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
> >  			clocks = <&mmsys CLK_MM_DISP_AAL0>;
> > +			mediatek,gce-client-reg = <&gce SUBSYS_1401XXXX 0 0x1000>;
> >  		};
> >  
> >  		gamma0: gamma@14011000 {
> > @@ -741,6 +753,7 @@
> >  			interrupts = <GIC_SPI 234 IRQ_TYPE_LEVEL_LOW>;
> >  			power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
> >  			clocks = <&mmsys CLK_MM_DISP_GAMMA0>;
> > +			mediatek,gce-client-reg = <&gce SUBSYS_1401XXXX 0x1000 0x1000>;
> >  		};
> >  
> >  		dither0: dither@14012000 {
> > @@ -749,6 +762,7 @@
> >  			interrupts = <GIC_SPI 235 IRQ_TYPE_LEVEL_LOW>;
> >  			power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
> >  			clocks = <&mmsys CLK_MM_DISP_DITHER0>;
> > +			mediatek,gce-client-reg = <&gce SUBSYS_1401XXXX 0x2000 0x1000>;
> >  		};
> >  
> >  		mutex: mutex@14016000 {
> > @@ -756,6 +770,8 @@
> >  			reg = <0 0x14016000 0 0x1000>;
> >  			interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_LOW>;
> >  			power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
> > +			mediatek,gce-events = <CMDQ_EVENT_MUTEX_STREAM_DONE0>,
> > +					      <CMDQ_EVENT_MUTEX_STREAM_DONE1>;
> >  		};
> >  
> >  		smi_common: smi@14019000 {
> 
>