Re: [PATCH 1/1] net: ethernet: stmmac: simplify phy modes management for stm32

From: Christophe ROULLIER
Date: Thu Feb 13 2020 - 02:03:49 EST


Gentle reminder

Thanks

On 1/30/20 2:29 PM, Christophe ROULLIER wrote:
> On 1/29/20 11:51 AM, David Miller wrote:
>> From: Christophe Roullier <christophe.roullier@xxxxxx>
>> Date: Tue, 28 Jan 2020 09:39:42 +0100
>>
>>> No new feature, just to simplify stm32 part to be easier to use.
>>> Add by default all Ethernet clocks in DT, and activate or not in
>>> function
>>> of phy mode, clock frequency, if property "st,ext-phyclk" is set or
>>> not.
>>> Keep backward compatibility
>>> -----------------------------------------------------------------------
>>> |PHY_MODE | Normal | PHY wo crystal| PHY wo crystal | No 125Mhz |
>>> |ÂÂÂÂÂÂÂÂ |ÂÂÂÂÂÂÂ |ÂÂÂÂÂ 25MHzÂÂÂ |ÂÂÂÂÂÂÂ 50MHzÂÂÂÂÂÂ | from PHYÂÂ |
>>> -----------------------------------------------------------------------
>>> | MII | - | eth-ck | n/a | n/a |
>>> |ÂÂÂÂÂÂÂÂ |ÂÂÂÂÂÂÂ | st,ext-phyclk | |ÂÂÂÂÂÂÂÂÂÂÂÂ |
>>> -----------------------------------------------------------------------
>>> | GMII | - | eth-ck | n/a | n/a |
>>> |ÂÂÂÂÂÂÂÂ |ÂÂÂÂÂÂÂ | st,ext-phyclk | |ÂÂÂÂÂÂÂÂÂÂÂÂ |
>>> -----------------------------------------------------------------------
>>> | RGMII | - | eth-ck | n/a | eth-ck |
>>> |ÂÂÂÂÂÂÂÂ |ÂÂÂÂÂÂÂ | st,ext-phyclk | |st,eth-clk-sel|
>>> |ÂÂÂÂÂÂÂÂ |ÂÂÂÂÂÂÂ |ÂÂÂÂÂÂÂÂÂÂÂÂÂÂ | |ÂÂÂÂÂÂ orÂÂÂÂ |
>>> |ÂÂÂÂÂÂÂÂ |ÂÂÂÂÂÂÂ |ÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |
>>> st,ext-phyclk|
>>> ------------------------------------------------------------------------
>>>
>>> | RMII | - | eth-ck | eth-ck | n/a |
>>> |ÂÂÂÂÂÂÂÂ |ÂÂÂÂÂÂÂ | st,ext-phyclk | st,eth-ref-clk-sel
>>> |ÂÂÂÂÂÂÂÂÂÂÂÂÂ |
>>> |ÂÂÂÂÂÂÂÂ |ÂÂÂÂÂÂÂ |ÂÂÂÂÂÂÂÂÂÂÂÂÂÂ | or st,ext-phyclk |ÂÂÂÂÂÂÂÂÂÂÂÂÂ |
>>> ------------------------------------------------------------------------
>>>
>>>
>>> Signed-off-by: Christophe Roullier <christophe.roullier@xxxxxx>
>> If anything, this is more of a cleanup, and therefore only
>> appropriate for
>> net-next when it opens back up.
> Thanks David, It is not urgent, do you want that I re-push it with
> "PATCH net next" ?