Re: [RFC PATCH 0/2] arm64 kgdb fixes for single stepping

From: Will Deacon
Date: Thu Feb 13 2020 - 05:11:05 EST


On Wed, Feb 12, 2020 at 09:11:29PM -0600, minyard@xxxxxxx wrote:
> I got a bug report about using kgdb on arm64, and it turns out it was
> fairly broken. Patch 2 has a description of what was going on. I am
> using a Marvell 8100 board.
>
> The following patches fix the problem, but probably not in the
> best way. They are what I hacked out to show the problems.
>
> I am not quite sure how this will interact with kprobes and hardware
> breakpoints which use the same code, but they would have been broken,
> too, so this is not making them any worse.

This should all be handled by kgdb itself, not by changing the low-level
debug exception handling. For example, the '&kgdb_step_hook' can take
care of re-arming the step state machine and kgdb can also simply disable
interrupts during the step if it doesn't want to step into the handler.

Will