Re: [PATCH v6 0/6] clone3 & cgroups: allow spawning processes into cgroups

[Christian Brauner]

On Wed, Feb 12, 2020 at 06:01:27PM -0500, Tejun Heo wrote:
> On Wed, Feb 05, 2020 at 02:26:17PM +0100, Christian Brauner wrote:
> > Hey Tejun,
> > 
> > This is v6 of the promised series to enable spawning processes into a
> > target cgroup different from the parent's cgroup.
> 
> Applied 1-6 to cgroup/for-5.7. There was a conflict with 0cd9d33ace33
> ("cgroup: init_tasks shouldn't be linked to the root cgroup") which
> got fixed up while applying. I'd really appreciate if you can take a
> look to see everything is ok.

Looked at it just now and all seems sane.
The reference to init_tasks threw me off at first. I initially thought
you're talking about pid namespace inits but you mean tasks created via
fork_idle() here. Since those tasks can't be created with
CLONE_INTO_CGROUP set it's perfectly safe to set cset = NULL
unconditionally.
Thanks for fixing the merge conflict!
> 
> Thanks a lot for working on this. This is really great.

Thanks, I think so too!
Christian