Re: [PATCH v2 3/4] libnvdimm/region: Introduce NDD_LABELING

From: Jeff Moyer
Date: Thu Feb 13 2020 - 14:13:00 EST


Dan Williams <dan.j.williams@xxxxxxxxx> writes:

> @@ -312,8 +312,9 @@ static ssize_t flags_show(struct device *dev,
> {
> struct nvdimm *nvdimm = to_nvdimm(dev);
>
> - return sprintf(buf, "%s%s\n",
> + return sprintf(buf, "%s%s%s\n",
> test_bit(NDD_ALIASING, &nvdimm->flags) ? "alias " : "",
> + test_bit(NDD_LABELING, &nvdimm->flags) ? "label" : "",
^

Missing a space.

The rest looks sane.

Reviewed-by: Jeff Moyer <jmoyer@xxxxxxxxxx>