Re: linux-next: build warning after merge of the slave-dma tree
From: Vinod Koul
Date: Thu Feb 13 2020 - 23:41:19 EST
Hello Stephen,
On 14-02-20, 11:00, Stephen Rothwell wrote:
> Hi all,
>
> After merging the slave-dma tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> drivers/dma/sun4i-dma.c: In function 'sun4i_dma_prep_dma_cyclic':
> drivers/dma/sun4i-dma.c:30:51: warning: statement with no effect [-Wunused-value]
> 30 | #define SUN4I_DMA_CFG_SRC_ADDR_MODE(mode) ((mode) << 5)
> | ~~~~~~~~^~~~~
> drivers/dma/sun4i-dma.c:701:8: note: in expansion of macro 'SUN4I_DMA_CFG_SRC_ADDR_MODE'
> 701 | SUN4I_DMA_CFG_SRC_ADDR_MODE(linear_mode);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Introduced by commit
>
> 6ebb827f7aad ("dmaengine: sun4i: use 'linear_mode' in sun4i_dma_prep_dma_cyclic")
Thanks for the report, I confirm this and the fix is on the way :)
> Please do not ignore/dismiss new warnings ... this one points out a real issue.
Sure!
--
~Vinod