Re: [PATCH 5.4 00/96] 5.4.20-stable review

[Geert Uytterhoeven]

Hi GÃnter,

On Thu, Feb 13, 2020 at 11:28 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
> On Thu, Feb 13, 2020 at 07:20:07AM -0800, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 5.4.20 release.
> > There are 96 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Sat, 15 Feb 2020 15:16:40 +0000.
> > Anything received after that time might be too late.
> >
>
> Build reference: v5.4.19-98-gdfae536f94c2
> gcc version: powerpc64-linux-gcc (GCC) 9.2.0
>
> Building powerpc:defconfig ... failed
> --------------
> Error log:
> drivers/rtc/rtc-ds1307.c:1570:21: error: variable 'regmap_config' has initializer but incomplete type
>  1570 | static const struct regmap_config regmap_config = {
>
> Bisect log below. Looks like the the definition of "not needed"
> needs an update.

"not needed" goes together with (or after) "when necessary":
578c2b661e2b1b47 ("rtc: Kconfig: select REGMAP_I2C when necessary")

> v5.5.y has the same problem.
>
> Guenter
>
> ---
> # bad: [dfae536f94c22d5fd109d5db73cd5ed7245a764c] Linux 5.4.20-rc1
> # good: [d6591ea2dd1a44b1c72c5a3e3b6555d7585acdae] Linux 5.4.19
> git bisect start 'HEAD' 'v5.4.19'
> # bad: [f52a8d450b1431b775d993cd8586f0cfd5fe25e1] ARM: dts: at91: sama5d3: fix maximum peripheral clock rates
> git bisect bad f52a8d450b1431b775d993cd8586f0cfd5fe25e1
> # good: [99323d91be3464a8ff87c7b16c72e7134b7b5075] selftests/bpf: Test freeing sockmap/sockhash with a socket in it
> git bisect good 99323d91be3464a8ff87c7b16c72e7134b7b5075
> # bad: [4ece240000532dbe0628f28f3f5466ed4091613b] rtc: i2c/spi: Avoid inclusion of REGMAP support when not needed
> git bisect bad 4ece240000532dbe0628f28f3f5466ed4091613b
> # good: [3a0805bedf5a29ff659d82b34ccf8f393820a5f1] NFS: Fix fix of show_nfs_errors
> git bisect good 3a0805bedf5a29ff659d82b34ccf8f393820a5f1
> # good: [bd35cae202fa94fe8349ea63ea082f190b31692c] NFSv4.0: nfs4_do_fsinfo() should not do implicit lease renewals
> git bisect good bd35cae202fa94fe8349ea63ea082f190b31692c
> # good: [d052da5a3c584de39b4b74176b37925d58ab4239] rtc: hym8563: Return -EINVAL if the time is known to be invalid
> git bisect good d052da5a3c584de39b4b74176b37925d58ab4239
> # first bad commit: [4ece240000532dbe0628f28f3f5466ed4091613b] rtc: i2c/spi: Avoid inclusion of REGMAP support when not needed

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds