Re: [PATCH] ARM: dts: sun5i: Add dts for inet86v_rev2

[Maxime Ripard]

Hi,

On Wed, Feb 12, 2020 at 10:45:03AM +0100, Alexandre GRIVEAUX wrote:
> Le 11/02/2020 à 14:15, Maxime Ripard a écrit :
> > On Mon, Feb 10, 2020 at 11:35:52AM +0100, agriveaux@xxxxxxxxxxxx wrote:
> >> From: Alexandre GRIVEAUX <agriveaux@xxxxxxxxxxxx>
> >>
> >> Add Inet 86V Rev 2 support, based upon Inet 86VS.
> >>
> >> Missing things:
> >> - Accelerometer (MXC6225X)
> >> - Touchpanel (Sitronix SL1536)
> >> - Nand (29F32G08CBACA)
> >> - Camera (HCWY0308)
> >>
> >> Signed-off-by: Alexandre GRIVEAUX <agriveaux@xxxxxxxxxxxx>
> > Please read the documentation I sent you yesterday. In particular,
> > when submitting multiple versions, you should remove have the version
> > number in the title and a changelog.
> >
> > Also, please ask questions if you're unsure about something, or
> > discuss something you do not agree with instead of ignoring the
> > comment.
> >
> > Maxime
>
>
> Seem I misusing 'git send-email' because i already changed the subject
> line (same apply to u-boot):
>
> git send-email --from agriveaux@xxxxxxxxxxxx --to
> robh+dt@xxxxxxxxxx,mark.rutland@xxxxxxx,mripard@xxxxxxxxxx,wens@xxxxxxxx
> --cc
> linux-kernel@xxxxxxxxxxxxxxx,devicetree@xxxxxxxxxxxxxxx,agriveaux@xxxxxxxxxxxx
> --subject '[v2] ARM: dts: sun5i: Add dts for inet86v_rev2' --compose
> /tmp/linux/0001-ARM-dts-sun5i-Add-dts-for-inet86v_rev2.patch
>
> It's the first time i use git send-email, previously i used mutt to send
> patchsets (on mips mostly).
>
>
> Effectively i've forgot the changelog...

A simpler way, especially for a single patch, would be to use

git send-email -v2 --to $recipients --annotate $COMMIT^..$COMMIT

You can even keep the change log in the commit log itself by using ---
as a separator, so something like:

ARM: dts: my super title

Some nice awesome change

---

Changes from v1:
  - Whatever.

> At why do we need another device tree:
>
> inet86vs use a GSL1680 touchpanel controller and 4GB nand [0]
>
> inet86vsuse a Sitonix SL1536 touchpanel controller and 8GB nand (can
> have 16GB nand)[1]

NAND size will be discovered so it's not really a concern. For the
touchscreen, you should make that clear in your commit log.

Maxime

Attachment: signature.asc
Description: PGP signature