Re: [PATCH v2 01/12] drm: ingenic-drm: add MODULE_DEVICE_TABLE

From: H. Nikolaus Schaller
Date: Fri Feb 14 2020 - 14:24:58 EST



> Am 14.02.2020 um 20:06 schrieb Paul Cercueil <paul@xxxxxxxxxxxxxxx>:
>
> Hi Nikolaus,
>
> Please rebase this patch on top of drm-misc-next and send it apart - it should go through the DRM tree.
>
>
> Le ven., févr. 14, 2020 at 17:10, H. Nikolaus Schaller <hns@xxxxxxxxxxxxx> a écrit :
>> Add MODULE_DEVICE_TABLE so that the driver can load by
>> matching the device tree if compiled as module.
>> Signed-off-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>
>> ---
>> drivers/gpu/drm/ingenic/ingenic-drm.c | 2 ++
>> 1 file changed, 2 insertions(+)
>> diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c b/drivers/gpu/drm/ingenic/ingenic-drm.c
>> index 6d47ef7b148c..d8617096dd8e 100644
>> --- a/drivers/gpu/drm/ingenic/ingenic-drm.c
>> +++ b/drivers/gpu/drm/ingenic/ingenic-drm.c
>> @@ -844,6 +844,8 @@ static const struct of_device_id ingenic_drm_of_match[] = {
>> { /* sentinel */ },
>> };
>> +MODULE_DEVICE_TABLE(of, ingenic_drm_of_match);
>
> Also please remove the blank line above MODULE_DEVICE_TABLE.
>
> Cheers,
> -Paul

Ok.

BR and thanks,
Nikolaus

>
>> +
>> static struct platform_driver ingenic_drm_driver = {
>> .driver = {
>> .name = "ingenic-drm",
>> --
>> 2.23.0
>
>