Re: [RFC PATCH 0/2] soundwire: add master_device/driver support
From: Greg KH
Date: Fri Feb 14 2020 - 15:02:46 EST
On Fri, Jan 31, 2020 at 10:20:09PM -0600, Pierre-Louis Bossart wrote:
> The SoundWire master representation needs to evolve to take into account:
>
> a) a May 2019 recommendation from Greg KH to remove platform devices
>
> b) the need on Intel platforms to support hardware startup only once
> the power rail dependencies are settled. The SoundWire master is not
> an independent IP at all.
>
> c) the need to deal with external wakes handled by the PCI subsystem
> in specific low-power modes
>
> In case it wasn't clear, the SoundWire subsystem is currently unusable
> with v5.5 on devices hitting the shelves very soon (race conditions,
> power management, suspend/resume, etc). v5.6 will only provide
> interface changes and no functional improvement. We've circled on the
> same concepts since September 2019, and I hope this direction is now
> aligned with the suggestions from Vinod Koul and that we can target
> v5.7 as the 'SoundWire just works(tm)' version.
>
> This series is provided as an RFC since it depends on patches already
> for review.
Both of these look sane to me, nice work!
Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>