Re: [PATCH v6 2/6] lib: introduce generic min-heap

[Randy Dunlap]

Hi,

On 2/13/20 11:51 PM, Ian Rogers wrote:
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 1458505192cd..e61e7fee9364 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1771,6 +1771,16 @@ config TEST_LIST_SORT
>  
>  	  If unsure, say N.
>  
> +config TEST_MIN_HEAP
> +	tristate "Min heap test"
> +	depends on DEBUG_KERNEL || m

I realize that this is (likely) copied from other config entries,
but the "depends on DEBUG_KERNEL || m" doesn't make any sense to me.
Seems like it should be "depends on DEBUG_KERNEL && m"...

Why should it be "||"??


> +	help
> +	  Enable this to turn on min heap function tests. This test is
> +	  executed only once during system boot (so affects only boot time),
> +	  or at module load time.
> +
> +	  If unsure, say N.
> +
>  config TEST_SORT
>  	tristate "Array-based sort test"
>  	depends on DEBUG_KERNEL || m


thanks.
-- 
~Randy