Re: [PATCH AUTOSEL 5.5 155/542] drm/amdkfd: remove set but not used variable 'top_dev'

[Sasha Levin]

On Fri, Feb 14, 2020 at 04:44:29PM -0500, Greg KH wrote:
> On Fri, Feb 14, 2020 at 10:42:27AM -0500, Sasha Levin wrote:
> > From: zhengbin <zhengbin13@xxxxxxxxxx>
> >
> > [ Upstream commit d191bd678153307573d615bb42da4fcca19fe477 ]
> >
> > Fixes gcc '-Wunused-but-set-variable' warning:
> >
> > drivers/gpu/drm/amd/amdkfd/kfd_iommu.c: In function kfd_iommu_device_init:
> > drivers/gpu/drm/amd/amdkfd/kfd_iommu.c:65:30: warning: variable top_dev set but not used [-Wunused-but-set-variable]
> >
> > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> > Fixes: 1ae99eab34f9 ("drm/amdkfd: Initialize HSA_CAP_ATS_PRESENT capability in topology codes")
> > Signed-off-by: zhengbin <zhengbin13@xxxxxxxxxx>
> > Reviewed-by: Felix Kuehling <Felix.Kuehling@xxxxxxx>
> > Signed-off-by: Felix Kuehling <Felix.Kuehling@xxxxxxx>
> > Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>
> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> > ---
> >  drivers/gpu/drm/amd/amdkfd/kfd_iommu.c | 3 ---
> >  1 file changed, 3 deletions(-)
>
> Unless all of these "unused bt set variable" patches are needed for
> "real" fixes, there's no need to add them here as we are NOT building
> the kernel with that option enabled any time soon from what I can tell.
>
> So you can drop a ton of these patches from all of these AUTOSEL
> branches please.

Sigh, I confused the -Wno-unused-but-set-variable flag we pass in the
makefile with -Wunused-but-set-variable. Sorry about all this noise,
I'll drop it.

--
Thanks,
Sasha