Re: [PATCH 2/4] perf expr: Move expr lexer to flex

[Jiri Olsa]

On Fri, Feb 21, 2020 at 04:23:12PM -0800, Andi Kleen wrote:
> > +max		{ return MAX; }
> > +min		{ return MIN; }
> > +if		{ return IF; }
> > +else		{ return ELSE; }
> > +#smt_on		{ return SMT_ON; }
> > +{number}	{ return value(yyscanner, 10); }
> > +{symbol}	{ return str(yyscanner, ID); }
> > +"|"		{ return '|'; }
> > +"^"		{ return '^'; }
> > +"&"		{ return '&'; }
> > +"-"		{ return '-'; }
> > +"+"		{ return '+'; }
> > +"*"		{ return '*'; }
> > +"/"		{ return '/'; }
> > +"%"		{ return '%'; }
> > +"("		{ return '('; }
> > +")"		{ return ')'; }
> > +","		{ return ','; }
> 
> Didn't think there was a comma, but ok.

actually it's for the min/max functions arguments separation
I posted v2

jirka

> 
> Looks reasonable to me.
> 
> -Andi
>