Re: [PATCH v2 2/4] tpm: ibmvtpm: Wait for buffer to be set before proceeding

From: Stefan Berger
Date: Tue Feb 25 2020 - 13:14:44 EST


On 2/25/20 11:57 AM, Jarkko Sakkinen wrote:
On Thu, Feb 13, 2020 at 03:23:27PM -0500, Stefan Berger wrote:
From: Stefan Berger <stefanb@xxxxxxxxxxxxx>

Synchronize with the results from the CRQs before continuing with
the initialization. This avoids trying to send TPM commands while
the rtce buffer has not been allocated, yet.
What is CRQ anyway an acronym of?

Command request queue.



This patch fixes an existing race condition that may occurr if the
hypervisor does not quickly respond to the VTPM_GET_RTCE_BUFFER_SIZE
request sent during initialization and therefore the ibmvtpm->rtce_buf
has not been allocated at the time the first TPM command is sent.
If it fixes a race condition, why doesn't it have a fixes tag?

Which commit should I mention?

 Stefan



/Jarkko