re: net: UDP tunnel encapsulation module for tunnelling different

[Colin Ian King]

Hi,

Static analysis with Coverity detected an issue in function
bareudp_xmit_skb with the return of an uninitialized value in variable
err in the following commit:

commit 571912c69f0ed731bd1e071ade9dc7ca4aa52065
Author: Martin Varghese <martin.varghese@xxxxxxxxx>
Date:   Mon Feb 24 10:57:50 2020 +0530

    net: UDP tunnel encapsulation module for tunnelling different
protocols like MPLS, IP, NSH etc.

The analysis is as follows:

var_decl: Declaring variable err without initializer.

301        int err;
302

...

344 free_dst:
345        dst_release(&rt->dst);

Uninitialized scalar variable (UNINIT)
uninit_use: Using uninitialized value err.

346        return err;
347 }

and also in function bareudp6_xmit_skb:

var_decl: Declaring variable err without initializer.

364        int err;
365

...

404
405 free_dst:
406        dst_release(dst);

Uninitialized scalar variable (UNINIT)
uninit_use: Using uninitialized value err.

407        return err;
408 }

Colin