Re: [PATCH v2] mm/vmscan: fix data races at kswapd_classzone_idx

From: Qian Cai
Date: Wed Feb 26 2020 - 06:50:06 EST




> On Feb 25, 2020, at 11:06 PM, Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:
>
> I don't understand why the usages of kswapd_classzone_idx in kswapd() and
> kswapd_try_to_sleep() don't need changing too? kswapd_classzone_idx()
> looks safe to me, but I'm prone to missing stupid things that compilers
> are allowed to do.

I am not sure. Although it looks possible on paper, I am wondering why KCSAN did not trigger it yet which seems rather common. I did stress testing those areas with KCSAN for a few months now, but it might just be that I missed the report at the first place.

Iâll keep running some testing to confirm it, but until that happens or someone else could confirm it could happen, Iâll leave it out for this version. We can always submit an incremental patch later if necessary.