Re: [PATCH v3 0/2] perf report: Support annotation of code without symbols

[Jin, Yao]

On 2/27/2020 9:50 PM, Arnaldo Carvalho de Melo wrote:
> Em Mon, Feb 24, 2020 at 10:22:23AM +0800, Jin Yao escreveu:
> > For perf report on stripped binaries it is currently impossible to do
> > annotation. The annotation state is all tied to symbols, but there are
> > either no symbols, or symbols are not covering all the code.
> >
> > We should support the annotation functionality even without symbols.
> >
> > The first patch uses al_addr to print because it's easy to dump
> > the instructions from this address in binary for branch mode.
> >
> > The second patch supports the annotation on stripped binary.
>
> I'm considering this a new feature, so I'll leave this for perf/core,
> i.e. for the next release, ok?

Yes, it's a new feature, so perf/core branch is OK. Thanks! :)

BTW, v3 is old, I just post v5 according to Jiri's comments.

> I'm now going thru the pure fixes that should go to perf/urgent, please
> holler if something you think should go in now is not in my perf/urgent
> branch.
>  > - Arnaldo

In summary, I have some patch series waiting but I think they can be in 
perf/core.

https://lkml.org/lkml/2020/2/2/83
https://lkml.org/lkml/2020/2/14/136
https://lkml.org/lkml/2020/2/19/1274
https://lkml.org/lkml/2020/2/26/1348

Following is a fix, maybe it can be in perf/urgent.

"perf stat: Align the output for interval aggregation mode"
https://lkml.org/lkml/2020/2/20/321

Thanks
Jin Yao

> >   v3:
> >   ---
> >   Keep just the ANNOTATION_DUMMY_LEN, and remove the
> >   opts->annotate_dummy_len since it's the "maybe in future
> >   we will provide" feature.
> >
> >   v2:
> >   ---
> >   Fix a crash issue when annotating an address in "unknown" object.
> >
> > Jin Yao (2):
> >    perf util: Print al_addr when symbol is not found
> >    Support interactive annotation of code without symbols
> >
> >   tools/perf/ui/browsers/hists.c | 43 +++++++++++++++++++++++++++++-----
> >   tools/perf/util/annotate.h     |  1 +
> >   tools/perf/util/sort.c         |  6 +++--
> >   3 files changed, 42 insertions(+), 8 deletions(-)
> >
> > --
> > 2.17.1