Re: [RFC 2/3] mm: Add a new page flag PageLayzyFree() for MADV_FREE
From: Huang\, Ying
Date: Fri Feb 28 2020 - 01:48:08 EST
David Hildenbrand <david@xxxxxxxxxx> writes:
>> Am 28.02.2020 um 04:38 schrieb Huang, Ying <ying.huang@xxxxxxxxx>:
>>
>> ïFrom: Huang Ying <ying.huang@xxxxxxxxx>
>>
>> Now !PageSwapBacked() is used as the flag for the pages freed lazily
>> via MADV_FREE. This isn't obvious enough. So Dave suggested to add a
>> new page flag for that to improve the code readability.
>
> This patch subject and description is *really* confusing. Youâre adding a helper function, not a page flag. Itâs a fairly easy refactoring.
Yes. Thanks for reminding. I will revise this in the next version.
Best Regards,
Huang, Ying
> (Adding new page flags is close to impossible).
>
> Cheers!