Re: [PATCH 4.19 60/97] lib/stackdepot: Fix outdated comments

[Pavel Machek]

Hi!

> [ Upstream commit ee050dc83bc326ad5ef8ee93bca344819371e7a5 ]
> 
> Replace "depot_save_stack" with "stack_depot_save" in code comments because
> depot_save_stack() was replaced in commit c0cfc337264c ("lib/stackdepot:
> Provide functions which operate on plain storage arrays") and removed in
> commit 56d8f079c51a ("lib/stackdepot: Remove obsolete functions")

This is wrong.

> +++ b/lib/stackdepot.c
> @@ -96,7 +96,7 @@ static bool init_stack_slab(void **prealloc)
>  		stack_slabs[depot_index + 1] = *prealloc;
>  		/*
>  		 * This smp_store_release pairs with smp_load_acquire() from
> -		 * |next_slab_inited| above and in depot_save_stack().
> +		 * |next_slab_inited| above and in stack_depot_save().
>  		 */
>  		smp_store_release(&next_slab_inited, 1);
>  	}

May have been outdated for mainline, but they are actually okay for
4.19.

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: PGP signature