Re: [PATCH] genirq/debugfs: add new config option for trigger interrupt from userspace

From: Marc Zyngier
Date: Fri Feb 28 2020 - 11:37:21 EST


Hi Joe,

On 2020-02-28 05:42, Joe Jin wrote:
commit 536e2e34bd00 ("genirq/debugfs: Triggering of interrupts from
userspace") is allowed developer inject interrupts via irq debugfs, which
is very useful during development phase, but on a production system, this
is very dangerous, add new config option, developers can enable it as
needed instead of enabling it by default when irq debugfs is enabled.

I don't really mind the patch (although it could be more elegant), but in
general I object to most debugfs options being set on a production kernel.
There is way too much information in most debugfs backends to be comfortable
with it, and you can find things like page table dumps, for example...

M.
--
Jazz is not dead. It just smells funny...