Re: [PATCH] KVM: SVM: Fix svm the vmexit error_code of WRMSR

[Paolo Bonzini]

On 02/03/20 13:54, Vitaly Kuznetsov wrote:
>>          enum exit_fastpath_completion *exit_fastpath)
>>   {
>>          if (!is_guest_mode(vcpu) &&
>> -               to_svm(vcpu)->vmcb->control.exit_code ==
>> EXIT_REASON_MSR_WRITE)
> There is an extra newline here (in case it's not just me).

Yes, the whole patch has broken newlines.  I fixed it up and applied.

>> +               (to_svm(vcpu)->vmcb->control.exit_code == SVM_EXIT_MSR) &&
>> +               (to_svm(vcpu)->vmcb->control.exit_info_1 & 1))
>
> Could we add defines for '1' and '0', like
> SVM_EXITINFO_MSR_WRITE/SVM_EXITINFO_MSR_READ maybe?

We can eliminate "& 1" completely since that's what msr_interception does.

Paolo