Re: [PATCH v2 3/4] arm64: dts: qcom: sc7180: Enable soc sleep stats

[Maulik Shah]

On 2/28/2020 12:04 PM, Bjorn Andersson wrote:
> On Fri 21 Feb 00:49 PST 2020, Maulik Shah wrote:
>
> > SoC sleep stats provides various low power mode stats.
> >
> > Cc: devicetree@xxxxxxxxxxxxxxx
> > Signed-off-by: Maulik Shah <mkshah@xxxxxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/sc7180.dtsi | 5 +++++
> >   1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> > index 8011c5f..eee6d92 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> > @@ -745,6 +745,11 @@
> >   			};
> >   		};
> >   
> > +		rpmh_sleep_stats: soc-sleep-stats@c3f0000 {
> I don't see any reason to reference this node, so you should be able to
> omit the label(?)
Done. Will update in next revision.

Thanks,
Maulik
> > +			compatible = "qcom,rpmh-sleep-stats";
> > +			reg = <0 0xc3f0000 0 0x400>;
> Please pad the address to 8 digits and sort the nodes by address.
>
> Regards,
> Bjorn
Done. Will update in next revision.

Thanks,
Maulik
> > +		};
> > +
> >   		tcsr_mutex_regs: syscon@1f40000 {
> >   			compatible = "syscon";
> >   			reg = <0 0x01f40000 0 0x40000>;
> > --
> > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> > of Code Aurora Forum, hosted by The Linux Foundation

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation