Re: [PATCH] arch: arm64: xilinx: Make zynqmp_firmware driver optional

[Jolly Shah]

Hi Sudeep,

> ------Original Message------
> From: Sudeep.holla@xxxxxxx <sudeep.holla@xxxxxxx>
> Sent:  Wednesday, February 26, 2020 3:46AM
> To: Jolly Shah <jolly.shah@xxxxxxxxxx>
> Cc: Ard.biesheuvel@xxxxxxxxxx <ard.biesheuvel@xxxxxxxxxx>, 
Mingo@xxxxxxxxxx <mingo@xxxxxxxxxx>, 'Greg Kh' 
<gregkh@xxxxxxxxxxxxxxxxxxx>, Matt@xxxxxxxxxxxxxxxxxxx 
<matt@xxxxxxxxxxxxxxxxxxx>, Hkallweit1@xxxxxxxxx <hkallweit1@xxxxxxxxx>, 
Keescook@xxxxxxxxxxxx <keescook@xxxxxxxxxxxx>, Dmitry.torokhov@xxxxxxxxx 
<dmitry.torokhov@xxxxxxxxx>, Michal Simek <michal.simek@xxxxxxxxxx>, 
Rajan Vaja <rajanv@xxxxxxxxxx>, Linux-arm-kernel@xxxxxxxxxxxxxxxxxxx 
<linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, Linux-kernel@xxxxxxxxxxxxxxx 
<linux-kernel@xxxxxxxxxxxxxxx>, Tejas Patel <tejas.patel@xxxxxxxxxx>, 
Sudeep.holla@xxxxxxx <sudeep.holla@xxxxxxx>
> Subject: Re: [PATCH] arch: arm64: xilinx: Make zynqmp_firmware driver 
optional
>
> On Tue, Feb 25, 2020 at 04:04:20PM -0800, Jolly Shah wrote:
> > From: Tejas Patel <tejas.patel@xxxxxxxxxx>
> >
> > Make zynqmp_firmware driver as optional to disable it, if user don't
> > want to use default zynqmp firmware interface.
>
> This patch on it own is simple and looks fine. However I expect the
> single binary to work with and without this option on the same platform.
> If zynqmp_firmware is not critical, the system should continue to work
> fine either way. The zynqmp_firmware driver should gracefully exit with
> error(if any).

Sure. Will address it in next version.

Thanks,
Jolly Shah


> --
> Regards,
> Sudeep