Re: [RFC][PATCH] soc: qcom: rpmpd: Allow RPMPD driver to be loaded as a module

[Rajendra Nayak]

> > -core_initcall(rpmpd_init);
> > +module_init(rpmpd_init);
>
> Can't you keep this as core_initcall(), for the times when its builtin?
>
> Additionally I believe you should add a call to unregister the driver,

and implement a .remove?

> and drop the suppress_bind_attrs.
>
> > +MODULE_LICENSE("GPL");
>
> "GPL v2" per the SPDX?
>
> Regards,
> Bjorn
>
> > --
> > 2.17.1

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation