Re: [PATCH] spi: Remove CONFIG_ prefix from Kconfig select

[John Garry]

On 05/03/2020 16:01, Joe Perches wrote:
> On Thu, 2020-03-05 at 15:53 +0000, John Garry wrote:
> > On 05/03/2020 15:15, Joe Perches wrote:
> > > commit a2ca53b52e00 ("spi: Add HiSilicon v3xx SPI NOR flash
> > > controller driver") likely inadvertently used a select statement
> > > with a CONFIG_ prefix, remove the prefix.
> > >
> > > Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> >
> > It's a pity checkpatch can't pick this stuff up...
>
> You are free to write a rule and submit a patch.

I'm not opposed to the idea...

> The grammar is pretty hard to verify from a patch
> fragment though.
>
> There are 2 existing nominal false positives.
>
> $ git grep 'select\b.*\bCONFIG_' -- '*/Kconfig*'
> drivers/edac/Kconfig:     select CONFIG_ACPI_NFIT.
> drivers/edac/Kconfig:     select CONFIG_ACPI_NFIT.

Ah, that's in the help text. I guess that those can be ignored simply 
based on the indentation.

I also see these:

drivers/i2c/busses/Kconfig:       to also select CONFIG_TYPEC_FUSB302=m.
drivers/platform/chrome/Kconfig:        select CONFIG_MFD_CROS_EC_DEV

The 2nd looks like it's incorrect.

And then also:
$ git grep 'depends on\b.*\bCONFIG_' -- '*/Kconfig*'
samples/Kconfig:        depends on CONFIG_ANDROID_BINDERFS

Thanks,
John