Re: [PATCH] mm: Use fallthrough;

From: Sergey Senozhatsky
Date: Mon Mar 09 2020 - 00:19:35 EST


On (20/03/07 19:54), Joe Perches wrote:
> On Sun, 2020-03-08 at 12:18 +0900, Sergey Senozhatsky wrote:
> > On (20/03/06 23:58), Joe Perches wrote:
> > [..]
> > > --- a/mm/mempolicy.c
> > > +++ b/mm/mempolicy.c
> > > @@ -907,7 +907,6 @@ static void get_policy_nodemask(struct mempolicy *p, nodemask_t *nodes)
> > >
> > > switch (p->mode) {
> > > case MPOL_BIND:
> > > - /* Fall through */
> > > case MPOL_INTERLEAVE:
>
> Consecutive case labels do not need an interleaving fallthrough;
>
> ie: ditto

I see. Shall this be mentioned in the commit message, maybe?

-ss