Re: [PATCH 2/2] tty: serial: make SERIAL_SPRD not depend on ARCH_SPRD

[Geert Uytterhoeven]

Hi Chunyan,

On Mon, Mar 9, 2020 at 2:18 AM Chunyan Zhang <zhang.lyra@xxxxxxxxx> wrote:
> On Fri, 6 Mar 2020 at 20:41, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> > On Thu, Mar 5, 2020 at 11:33 AM Chunyan Zhang <zhang.lyra@xxxxxxxxx> wrote:
> > > From: Chunyan Zhang <chunyan.zhang@xxxxxxxxxx>
> > >
> > > Remove the dependency with ARCH_SPRD from sprd serial/console Kconfig-s,
> > > since we want them can be built-in when ARCH_SPRD is set as 'm'.
> >
> > Why would you want a serial driver for a specific platform to be builtin,
> > while all other platform support is modular?
>
> Oh, that's not this patch means.
>
> We just want serial driver can be builtin for any platform, so it

What would be the benefit of the user to be able to have the SPRD serial
driver built-in on any platform?  AFAIU, it supports only Spreadtrum
platforms.

> should not depend on a config which can be set as 'm' (i.e. ARCH_SPRD)
> , otherwise if the config was set as 'm', the serial driver can't be
> selected as 'y' then.

I ask about that as a reply to PATCH 1/2.

> That's what I mean.

> > > --- a/drivers/tty/serial/Kconfig
> > > +++ b/drivers/tty/serial/Kconfig
> > > @@ -1452,7 +1452,6 @@ config SERIAL_MEN_Z135
> > >
> > >  config SERIAL_SPRD
> > >         tristate "Support for Spreadtrum serial"
> > > -       depends on ARCH_SPRD
> > >         select SERIAL_CORE
> > >         help
> > >           This enables the driver for the Spreadtrum's serial.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds