Re: [PATCH] staging: greybus: Fix the irq API abuse

[Johan Hovold]

On Fri, Mar 06, 2020 at 02:24:13PM +0100, Thomas Gleixner wrote:
> Nothing outside of low level architecture code is supposed to look up
> interrupt descriptors and fiddle with them.
> 
> Replace the open coded abuse by calling generic_handle_irq().
> 
> This still does not explain why and in which context this connection
> magic is injecting interrupts in the first place and why this is correct
> and safe, but at least the API abuse is gone.

Yeah, there's more to that story. The interrupt-handling was known to
have issues, but I can't seem to find the details right now.

> Fixes: 036aad9d0224 ("greybus: gpio: add interrupt handling support")
> Fixes: 2611ebef8322 ("greybus: gpio: don't call irq-flow handler directly")
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>

Acked-by: Johan Hovold <johan@xxxxxxxxxx>

Johan