Re: [PATCH] Input: i8042 - Fix the selftest retry logic

[You-Sheng Yang]

On 2020-03-05 14:44, AceLan Kao wrote:
> @@ -955,7 +954,9 @@ static int i8042_controller_selftest(void)
>  		dbg("i8042 controller selftest: %#x != %#x\n",
>  		    param, I8042_RET_CTL_TEST);
>  		msleep(50);
> -	} while (i++ < 5);
> +	} while (++i < 5);
> +	if (i == 5)
> +		return -ENODEV;

I would like to propose a V2 for this. The original logic allows
continuation to device probe when selftest returns a different value
than expected, and this is no longer available with this patch.

>  #ifdef CONFIG_X86
>  	/*
> 

You-Sheng Yang

Attachment: signature.asc
Description: OpenPGP digital signature