Re: [PATCH v2 01/14] net: xilinx: temac: Relax Kconfig dependencies

From: Esben Haabendal
Date: Tue Mar 10 2020 - 07:55:49 EST


Andre Przywara <andre.przywara@xxxxxxx> writes:

> Similar to axienet, the temac driver is now architecture agnostic, and
> can be at least compiled for several architectures.
> Especially the fact that this is a soft IP for implementing in FPGAs
> makes the current restriction rather pointless, as it could literally
> appear on any architecture, as long as an FPGA is connected to the bus.
>
> The driver hasn't been actually tried on any hardware, it is just a
> drive-by patch when doing the same for axienet (a similar patch for
> axienet is already merged).
>
> This (temac and axienet) have been compile-tested for:
> alpha hppa64 microblaze mips64 powerpc powerpc64 riscv64 s390 sparc64
> (using kernel.org cross compilers).

The temac driver is being actively used on x86_64, so please include
that for future compile-tests of it.

> Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>
> Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xxxxxxxxxx>
> ---
> drivers/net/ethernet/xilinx/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/xilinx/Kconfig b/drivers/net/ethernet/xilinx/Kconfig
> index 6304ebd8b5c6..0810af8193cb 100644
> --- a/drivers/net/ethernet/xilinx/Kconfig
> +++ b/drivers/net/ethernet/xilinx/Kconfig
> @@ -32,7 +32,6 @@ config XILINX_AXI_EMAC
>
> config XILINX_LL_TEMAC
> tristate "Xilinx LL TEMAC (LocalLink Tri-mode Ethernet MAC) driver"
> - depends on PPC || MICROBLAZE || X86 || COMPILE_TEST
> select PHYLIB
> ---help---
> This driver supports the Xilinx 10/100/1000 LocalLink TEMAC

Acked-by: Esben Haabendal <esben@xxxxxxxxxx>