Re: [PATCH 1/3] i2c: qcom-geni: Let firmware specify irq trigger flags
From: Stephen Boyd
Date: Tue Mar 10 2020 - 11:35:18 EST
Quoting Wolfram Sang (2020-03-10 02:42:00)
> On Tue, Feb 04, 2020 at 11:31:50AM -0800, Stephen Boyd wrote:
> > We don't need to force IRQF_TRIGGER_HIGH here as the DT or ACPI tables
> > should take care of this for us. Just use 0 instead so that we use the
> > flags from the firmware. Also, remove specify dev_name() for the irq
> > name so that we can get better information in /proc/interrupts about
> > which device is generating interrupts.
> >
> > Cc: Girish Mahadevan <girishm@xxxxxxxxxxxxxx>
> > Cc: Dilip Kota <dkota@xxxxxxxxxxxxxx>
> > Cc: Alok Chauhan <alokc@xxxxxxxxxxxxxx>
> > Cc: Douglas Anderson <dianders@xxxxxxxxxxxx>
> > Signed-off-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>
>
> All patches look good, but this one doesn't build because dev is defined
> in the next patch only. I also can't apply patch 2 before 1, so please
> rebase and resend.
Ok.