Re: [PATCH] kmod: make request_module() return an error when autoloading is disabled
From: Luis Chamberlain
Date: Wed Mar 11 2020 - 02:32:25 EST
On Wed, Mar 11, 2020 at 06:55:30AM +0100, Josh Triplett wrote:
> On March 11, 2020 5:32:21 AM GMT+01:00, Luis Chamberlain <mcgrof@xxxxxxxxxx> wrote:
> >On Tue, Mar 10, 2020 at 03:37:31PM -0700, Eric Biggers wrote:
> >> However, request_module() should also
> >> correctly return an error when it fails. So let's make it return
> >> -ENOENT, which matches the error when the modprobe binary doesn't
> >exist.
> >
> >This is a user experience change though, and I wouldn't have on my
> >radar
> >who would use this, and expects the old behaviour. Josh, would you by
> >chance?
>
> I don't think this affects userspace. But I'd suggest Ben Hutchings (CCed).
It doesn't, so yes no verififcation needed. Thanks the quick response though!
Luis