Re: [PATCH] ath9k: Handle txpower changes even when TPC is disabled
From: Kalle Valo
Date: Wed Mar 11 2020 - 12:53:50 EST
Remi Pommarel <repk@xxxxxxxxxxxx> wrote:
> When TPC is disabled IEEE80211_CONF_CHANGE_POWER event can be handled to
> reconfigure HW's maximum txpower.
>
> This fixes 0dBm txpower setting when user attaches to an interface for
> the first time with the following scenario:
>
> ieee80211_do_open()
> ath9k_add_interface()
> ath9k_set_txpower() /* Set TX power with not yet initialized
> sc->hw->conf.power_level */
>
> ieee80211_hw_config() /* Iniatilize sc->hw->conf.power_level and
> raise IEEE80211_CONF_CHANGE_POWER */
>
> ath9k_config() /* IEEE80211_CONF_CHANGE_POWER is ignored */
>
> This issue can be reproduced with the following:
>
> $ modprobe -r ath9k
> $ modprobe ath9k
> $ wpa_supplicant -i wlan0 -c /tmp/wpa.conf &
> $ iw dev /* Here TX power is either 0 or 3 depending on RF chain */
> $ killall wpa_supplicant
> $ iw dev /* TX power goes back to calibrated value and subsequent
> calls will be fine */
>
> Fixes: 283dd11994cde ("ath9k: add per-vif TX power capability")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Remi Pommarel <repk@xxxxxxxxxxxx>
> Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxx>
Patch applied to ath-next branch of ath.git, thanks.
968ae2caad07 ath9k: Handle txpower changes even when TPC is disabled
--
https://patchwork.kernel.org/patch/11413917/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches