Re: [PATCH v2] power: supply: Allow charger manager can be built as a module

From: Baolin Wang
Date: Wed Mar 11 2020 - 22:36:22 EST


On Thu, Mar 12, 2020 at 6:18 AM Sebastian Reichel <sre@xxxxxxxxxx> wrote:
>
> Hi,
>
> On Mon, Mar 09, 2020 at 11:20:41AM +0800, Baolin Wang wrote:
> > On Sat, Mar 7, 2020 at 4:47 AM Sebastian Reichel <sre@xxxxxxxxxx> wrote:
> > > On Fri, Mar 06, 2020 at 10:34:10AM +0800, Baolin Wang wrote:
> > > > Allow charger manager can be built as a module like other charger
> > > > drivers.
> > > >
> > > > Signed-off-by: Baolin Wang <baolin.wang7@xxxxxxxxx>
> > > > ---
> > >
> > > Thanks, queued. I do not like this driver, but its the best we have
> > > at the moment.
> >
> > Thanks. I understood your concern, do you have any plan to re-design
> > the charger manager driver in kernel? Or do you have some thoughts
> > about re-designing it? Now we have some out of tree code to use the
> > old charger manger, and we'd like to change to the new charger manger
> > driver and upstream them.
>
> I don't have anything ready yet and not enough time unfortunately.
> The proper way would be to have something equivialent to charger-manager
> in the power-supply core. The core should be able to monitor batteries
> and handle connected chargers automatically. Also there shouldn't be
> any DT entry for the software managing the charger, since DT is about
> hardware.

OK. We'll think about it according to your suggestion. Thanks.

--
Baolin Wang