Re: [PATCH v2 1/2] misc: cleanup minor number definitions in c file into miscdevice.h

From: Herbert Xu
Date: Wed Mar 11 2020 - 23:12:16 EST


On Wed, Mar 11, 2020 at 03:16:53PM +0800, Zhenzhong Duan wrote:
> HWRNG_MINOR and RNG_MISCDEV_MINOR are duplicate definitions, use
> unified HWRNG_MINOR instead and moved into miscdevice.h
>
> ANSLCD_MINOR and LCD_MINOR are duplicate definitions, use unified
> LCD_MINOR instead and moved into miscdevice.h
>
> MISCDEV_MINOR is renamed to PXA3XX_GCU_MINOR and moved into
> miscdevice.h
>
> Other definitions are just moved without any change.
>
> Link: https://lore.kernel.org/lkml/20200120221323.GJ15860@xxxxxxx/t/
> Suggested-by: Arnd Bergmann <arnd@xxxxxxxx>
> Build-tested-by: Willy TARREAU <wtarreau@xxxxxxxxxxx>
> Build-tested-by: Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx>
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@xxxxxxxxx>
> Acked-by: Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx>
> Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
> arch/um/drivers/random.c | 4 +---
> drivers/auxdisplay/charlcd.c | 2 --
> drivers/auxdisplay/panel.c | 2 --
> drivers/char/applicom.c | 1 -
> drivers/char/nwbutton.h | 1 -
> drivers/char/toshiba.c | 2 --
> drivers/macintosh/ans-lcd.c | 2 +-
> drivers/macintosh/ans-lcd.h | 2 --
> drivers/macintosh/via-pmu.c | 3 ---
> drivers/sbus/char/envctrl.c | 2 --
> drivers/sbus/char/uctrl.c | 2 --
> drivers/video/fbdev/pxa3xx-gcu.c | 7 +++----
> include/linux/miscdevice.h | 10 ++++++++++
> kernel/power/user.c | 2 --
> 14 files changed, 15 insertions(+), 27 deletions(-)

Acked-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt