Re: [v1 4/6] arm64: dts: sdm845-db845c: Add pm_8998 gpio names

From: Bjorn Andersson
Date: Thu Mar 12 2020 - 01:13:49 EST


On Wed 11 Mar 05:34 PDT 2020, Robert Foss wrote:

> Add pm_8998 GPIO trace names. These names are defined in
> the 96boards db845c mezzanine schematic.
>
> Signed-off-by: Robert Foss <robert.foss@xxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 30 ++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> index a6b6837c3d68..e8c056d02ace 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> @@ -584,6 +584,36 @@
> };
> };
>
> +&pm8998_gpio {

Please sort nodes alphabetically by label.

Regards,
Bjorn

> + gpio-line-names =
> + "NC",
> + "NC",
> + "WLAN_SW_CTRL",
> + "NC",
> + "PM_GPIO5_BLUE_BT_LED",
> + "VOL_UP_N",
> + "NC",
> + "ADC_IN1",
> + "PM_GPIO9_YEL_WIFI_LED",
> + "CAM0_AVDD_EN",
> + "NC",
> + "CAM0_DVDD_EN",
> + "PM_GPIO13_GREEN_U4_LED",
> + "DIV_CLK2",
> + "NC",
> + "NC",
> + "NC",
> + "SMB_STAT",
> + "NC",
> + "NC",
> + "ADC_IN2",
> + "OPTION1",
> + "WCSS_PWR_REQ",
> + "PM845_GPIO24",
> + "OPTION2",
> + "PM845_SLB";
> +};
> +
> &cci {
> status = "ok";
> };
> --
> 2.20.1
>