Re: [RESEND PATCH 2/5] phy: sun4i-usb: add support for the USB PHY on suniv SoC

[Chen-Yu Tsai]

On Thu, Mar 12, 2020 at 2:51 PM Chen-Yu Tsai <wens@xxxxxxxx> wrote:
>
> On Tue, Mar 10, 2020 at 4:43 AM George Hilliard
> <thirtythreeforty@xxxxxxxxx> wrote:
> >
> > The suniv SoC has one USB OTG port connected to a MUSB controller.
> >
> > Add support for its USB PHY.
> >
> > Signed-off-by: Icenowy Zheng <icenowy@xxxxxxx>
>
> Not sure why Icenowy's SoB is here. If she was the original author, you
> are supposed to keep her name as the author.
>
> > Signed-off-by: George Hilliard <thirtythreeforty@xxxxxxxxx>
> > ---
> >  drivers/phy/allwinner/phy-sun4i-usb.c | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/drivers/phy/allwinner/phy-sun4i-usb.c b/drivers/phy/allwinner/phy-sun4i-usb.c
> > index 856927382248..5fb0c42fe8fd 100644
> > --- a/drivers/phy/allwinner/phy-sun4i-usb.c
> > +++ b/drivers/phy/allwinner/phy-sun4i-usb.c
> > @@ -98,6 +98,7 @@
> >  #define POLL_TIME                      msecs_to_jiffies(250)
> >
> >  enum sun4i_usb_phy_type {
> > +       suniv_f1c100s_phy,
> >         sun4i_a10_phy,
> >         sun6i_a31_phy,
> >         sun8i_a33_phy,
> > @@ -859,6 +860,14 @@ static int sun4i_usb_phy_probe(struct platform_device *pdev)
> >         return 0;
> >  }
> >
> > +static const struct sun4i_usb_phy_cfg suniv_f1c100s_cfg = {
> > +       .num_phys = 1,
> > +       .type = suniv_f1c100s_phy,
> > +       .disc_thresh = 3,
> > +       .phyctl_offset = REG_PHYCTL_A10,
> > +       .dedicated_clocks = true,
> > +};
> > +
> >  static const struct sun4i_usb_phy_cfg sun4i_a10_cfg = {
> >         .num_phys = 3,
> >         .type = sun4i_a10_phy,
> > @@ -973,6 +982,8 @@ static const struct sun4i_usb_phy_cfg sun50i_h6_cfg = {
> >  };
> >
> >  static const struct of_device_id sun4i_usb_phy_of_match[] = {
> > +       { .compatible = "allwinner,suniv-f1c100s-usb-phy",
> > +         .data = &suniv_f1c100s_cfg },
> >         { .compatible = "allwinner,sun4i-a10-usb-phy", .data = &sun4i_a10_cfg },
>
> Please use the same style (and ignore checkpatch.pl on this one).
>
> ChenYu
>
> >         { .compatible = "allwinner,sun5i-a13-usb-phy", .data = &sun5i_a13_cfg },
> >         { .compatible = "allwinner,sun6i-a31-usb-phy", .data = &sun6i_a31_cfg },


Also, please stick to the same ordering in the driver and the bindings.

FWIW, `sort` places "suniv" after all sun([4-9]|50)i variants.

ChenYu

> > --
> > 2.25.0
> >