RE: [PATCH v2 05/17] drm/arc: make arcgpu_debugfs_init() return 0.

From: Alexey Brodkin
Date: Thu Mar 12 2020 - 03:56:05 EST


Hi Wambui,

> -----Original Message-----
> From: Wambui Karuga <wambui.karugax@xxxxxxxxx>
> Sent: Tuesday, March 10, 2020 8:31 PM
> To: airlied@xxxxxxxx; daniel@xxxxxxxx; Alexey Brodkin <abrodkin@xxxxxxxxxxxx>
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx
> Subject: [PATCH v2 05/17] drm/arc: make arcgpu_debugfs_init() return 0.
>
> Since commit 987d65d01356 (drm: debugfs: make
> drm_debugfs_create_files() never fail), drm_debugfs_create_files() never
> fails and should return void. Therefore, remove its use as the
> return value of arcpgu_debugfs_init() and have the latter function return
> 0 directly.
>
> v2: convert the function to return 0 instead of void to avoid breaking
> the build and ensure that this individual patch compiles properly.
>
> References: https://lists.freedesktop.org/archives/dri-devel/2020-February/257183.html
> Signed-off-by: Wambui Karuga <wambui.karugax@xxxxxxxxx>

Thanks for the patch!

Acked-by: Alexey Brodkin <abrodkin@xxxxxxxxxxxx>