Re: [PATCH] drm/amdgpu: Stop using the DRIVER debugging flag for vblank debugging messages

[Alex Deucher]

Applied.  thanks!

Alex

On Fri, Jan 24, 2020 at 9:48 AM Harry Wentland <hwentlan@xxxxxxx> wrote:
>
> On 2020-01-23 8:07 p.m., Lyude Paul wrote:
> > These are some very loud debug statements that get printed on every
> > vblank when driver level debug printing is enabled in DRM, and doesn't
> > really tell us anything that isn't related to vblanks. So let's move
> > this over to the proper debug flag to be a little less spammy with our
> > debug output.
> >
> > Signed-off-by: Lyude Paul <lyude@xxxxxxxxxx>
>
> Thanks. Great change.
>
> Reviewed-by: Harry Wentland <harry.wentland@xxxxxxx>
>
> Harry
>
> > ---
> >  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 14 ++++++++------
> >  1 file changed, 8 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > index 9402374d2466..3675e1c32707 100644
> > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > @@ -407,8 +407,9 @@ static void dm_vupdate_high_irq(void *interrupt_params)
> >       if (acrtc) {
> >               acrtc_state = to_dm_crtc_state(acrtc->base.state);
> >
> > -             DRM_DEBUG_DRIVER("crtc:%d, vupdate-vrr:%d\n", acrtc->crtc_id,
> > -                              amdgpu_dm_vrr_active(acrtc_state));
> > +             DRM_DEBUG_VBL("crtc:%d, vupdate-vrr:%d\n",
> > +                           acrtc->crtc_id,
> > +                           amdgpu_dm_vrr_active(acrtc_state));
> >
> >               /* Core vblank handling is done here after end of front-porch in
> >                * vrr mode, as vblank timestamping will give valid results
> > @@ -458,8 +459,9 @@ static void dm_crtc_high_irq(void *interrupt_params)
> >       if (acrtc) {
> >               acrtc_state = to_dm_crtc_state(acrtc->base.state);
> >
> > -             DRM_DEBUG_DRIVER("crtc:%d, vupdate-vrr:%d\n", acrtc->crtc_id,
> > -                              amdgpu_dm_vrr_active(acrtc_state));
> > +             DRM_DEBUG_VBL("crtc:%d, vupdate-vrr:%d\n",
> > +                           acrtc->crtc_id,
> > +                           amdgpu_dm_vrr_active(acrtc_state));
> >
> >               /* Core vblank handling at start of front-porch is only possible
> >                * in non-vrr mode, as only there vblank timestamping will give
> > @@ -522,8 +524,8 @@ static void dm_dcn_crtc_high_irq(void *interrupt_params)
> >
> >       acrtc_state = to_dm_crtc_state(acrtc->base.state);
> >
> > -     DRM_DEBUG_DRIVER("crtc:%d, vupdate-vrr:%d\n", acrtc->crtc_id,
> > -                             amdgpu_dm_vrr_active(acrtc_state));
> > +     DRM_DEBUG_VBL("crtc:%d, vupdate-vrr:%d\n", acrtc->crtc_id,
> > +                   amdgpu_dm_vrr_active(acrtc_state));
> >
> >       amdgpu_dm_crtc_handle_crc_irq(&acrtc->base);
> >       drm_crtc_handle_vblank(&acrtc->base);
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel